1TODO:
2
3From the initial code review:
4
5The main thing you need to do is to implement all the controls using the
6control framework (see Documentation/video4linux/v4l2-controls.txt).
7Most drivers are by now converted to the control framework, so you will
8find many examples of how to do this in drivers/media/radio.
9
10The sysfs stuff should be replaced by controls as well. A lot of the RDS
11support is now available as controls (although there may well be some
12missing features, but that is easy enough to add). Since the RDS data is
13actually read() from the device I am not sure whether the RDS
14properties/controls should be there at all.
15
16Correct Coding Style, as this driver also violates several Style
17rules, and do evil tricks, like returning from a function inside a
18macro.
19
20Finally this driver should probably be split up into two parts: one
21v4l2_subdev-based core driver and one platform driver. See e.g.
22radio-si4713/si4713-i2c.c as a good example. But I would wait with that
23until the rest of the driver is cleaned up. Then I have a better idea of
24whether this is necessary or not.
25