1/* 2 * drivers/net/bond/bond_options.c - bonding options 3 * Copyright (c) 2013 Jiri Pirko <jiri@resnulli.us> 4 * Copyright (c) 2013 Scott Feldman <sfeldma@cumulusnetworks.com> 5 * 6 * This program is free software; you can redistribute it and/or modify 7 * it under the terms of the GNU General Public License as published by 8 * the Free Software Foundation; either version 2 of the License, or 9 * (at your option) any later version. 10 */ 11 12#include <linux/errno.h> 13#include <linux/if.h> 14#include <linux/netdevice.h> 15#include <linux/spinlock.h> 16#include <linux/rcupdate.h> 17#include <linux/ctype.h> 18#include <linux/inet.h> 19#include <net/bonding.h> 20 21static int bond_option_active_slave_set(struct bonding *bond, 22 const struct bond_opt_value *newval); 23static int bond_option_miimon_set(struct bonding *bond, 24 const struct bond_opt_value *newval); 25static int bond_option_updelay_set(struct bonding *bond, 26 const struct bond_opt_value *newval); 27static int bond_option_downdelay_set(struct bonding *bond, 28 const struct bond_opt_value *newval); 29static int bond_option_use_carrier_set(struct bonding *bond, 30 const struct bond_opt_value *newval); 31static int bond_option_arp_interval_set(struct bonding *bond, 32 const struct bond_opt_value *newval); 33static int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target); 34static int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target); 35static int bond_option_arp_ip_targets_set(struct bonding *bond, 36 const struct bond_opt_value *newval); 37static int bond_option_arp_validate_set(struct bonding *bond, 38 const struct bond_opt_value *newval); 39static int bond_option_arp_all_targets_set(struct bonding *bond, 40 const struct bond_opt_value *newval); 41static int bond_option_primary_set(struct bonding *bond, 42 const struct bond_opt_value *newval); 43static int bond_option_primary_reselect_set(struct bonding *bond, 44 const struct bond_opt_value *newval); 45static int bond_option_fail_over_mac_set(struct bonding *bond, 46 const struct bond_opt_value *newval); 47static int bond_option_xmit_hash_policy_set(struct bonding *bond, 48 const struct bond_opt_value *newval); 49static int bond_option_resend_igmp_set(struct bonding *bond, 50 const struct bond_opt_value *newval); 51static int bond_option_num_peer_notif_set(struct bonding *bond, 52 const struct bond_opt_value *newval); 53static int bond_option_all_slaves_active_set(struct bonding *bond, 54 const struct bond_opt_value *newval); 55static int bond_option_min_links_set(struct bonding *bond, 56 const struct bond_opt_value *newval); 57static int bond_option_lp_interval_set(struct bonding *bond, 58 const struct bond_opt_value *newval); 59static int bond_option_pps_set(struct bonding *bond, 60 const struct bond_opt_value *newval); 61static int bond_option_lacp_rate_set(struct bonding *bond, 62 const struct bond_opt_value *newval); 63static int bond_option_ad_select_set(struct bonding *bond, 64 const struct bond_opt_value *newval); 65static int bond_option_queue_id_set(struct bonding *bond, 66 const struct bond_opt_value *newval); 67static int bond_option_mode_set(struct bonding *bond, 68 const struct bond_opt_value *newval); 69static int bond_option_slaves_set(struct bonding *bond, 70 const struct bond_opt_value *newval); 71static int bond_option_tlb_dynamic_lb_set(struct bonding *bond, 72 const struct bond_opt_value *newval); 73 74 75static const struct bond_opt_value bond_mode_tbl[] = { 76 { "balance-rr", BOND_MODE_ROUNDROBIN, BOND_VALFLAG_DEFAULT}, 77 { "active-backup", BOND_MODE_ACTIVEBACKUP, 0}, 78 { "balance-xor", BOND_MODE_XOR, 0}, 79 { "broadcast", BOND_MODE_BROADCAST, 0}, 80 { "802.3ad", BOND_MODE_8023AD, 0}, 81 { "balance-tlb", BOND_MODE_TLB, 0}, 82 { "balance-alb", BOND_MODE_ALB, 0}, 83 { NULL, -1, 0}, 84}; 85 86static const struct bond_opt_value bond_pps_tbl[] = { 87 { "default", 1, BOND_VALFLAG_DEFAULT}, 88 { "maxval", USHRT_MAX, BOND_VALFLAG_MAX}, 89 { NULL, -1, 0}, 90}; 91 92static const struct bond_opt_value bond_xmit_hashtype_tbl[] = { 93 { "layer2", BOND_XMIT_POLICY_LAYER2, BOND_VALFLAG_DEFAULT}, 94 { "layer3+4", BOND_XMIT_POLICY_LAYER34, 0}, 95 { "layer2+3", BOND_XMIT_POLICY_LAYER23, 0}, 96 { "encap2+3", BOND_XMIT_POLICY_ENCAP23, 0}, 97 { "encap3+4", BOND_XMIT_POLICY_ENCAP34, 0}, 98 { NULL, -1, 0}, 99}; 100 101static const struct bond_opt_value bond_arp_validate_tbl[] = { 102 { "none", BOND_ARP_VALIDATE_NONE, BOND_VALFLAG_DEFAULT}, 103 { "active", BOND_ARP_VALIDATE_ACTIVE, 0}, 104 { "backup", BOND_ARP_VALIDATE_BACKUP, 0}, 105 { "all", BOND_ARP_VALIDATE_ALL, 0}, 106 { "filter", BOND_ARP_FILTER, 0}, 107 { "filter_active", BOND_ARP_FILTER_ACTIVE, 0}, 108 { "filter_backup", BOND_ARP_FILTER_BACKUP, 0}, 109 { NULL, -1, 0}, 110}; 111 112static const struct bond_opt_value bond_arp_all_targets_tbl[] = { 113 { "any", BOND_ARP_TARGETS_ANY, BOND_VALFLAG_DEFAULT}, 114 { "all", BOND_ARP_TARGETS_ALL, 0}, 115 { NULL, -1, 0}, 116}; 117 118static const struct bond_opt_value bond_fail_over_mac_tbl[] = { 119 { "none", BOND_FOM_NONE, BOND_VALFLAG_DEFAULT}, 120 { "active", BOND_FOM_ACTIVE, 0}, 121 { "follow", BOND_FOM_FOLLOW, 0}, 122 { NULL, -1, 0}, 123}; 124 125static const struct bond_opt_value bond_intmax_tbl[] = { 126 { "off", 0, BOND_VALFLAG_DEFAULT}, 127 { "maxval", INT_MAX, BOND_VALFLAG_MAX}, 128 { NULL, -1, 0} 129}; 130 131static const struct bond_opt_value bond_lacp_rate_tbl[] = { 132 { "slow", AD_LACP_SLOW, 0}, 133 { "fast", AD_LACP_FAST, 0}, 134 { NULL, -1, 0}, 135}; 136 137static const struct bond_opt_value bond_ad_select_tbl[] = { 138 { "stable", BOND_AD_STABLE, BOND_VALFLAG_DEFAULT}, 139 { "bandwidth", BOND_AD_BANDWIDTH, 0}, 140 { "count", BOND_AD_COUNT, 0}, 141 { NULL, -1, 0}, 142}; 143 144static const struct bond_opt_value bond_num_peer_notif_tbl[] = { 145 { "off", 0, 0}, 146 { "maxval", 255, BOND_VALFLAG_MAX}, 147 { "default", 1, BOND_VALFLAG_DEFAULT}, 148 { NULL, -1, 0} 149}; 150 151static const struct bond_opt_value bond_primary_reselect_tbl[] = { 152 { "always", BOND_PRI_RESELECT_ALWAYS, BOND_VALFLAG_DEFAULT}, 153 { "better", BOND_PRI_RESELECT_BETTER, 0}, 154 { "failure", BOND_PRI_RESELECT_FAILURE, 0}, 155 { NULL, -1}, 156}; 157 158static const struct bond_opt_value bond_use_carrier_tbl[] = { 159 { "off", 0, 0}, 160 { "on", 1, BOND_VALFLAG_DEFAULT}, 161 { NULL, -1, 0} 162}; 163 164static const struct bond_opt_value bond_all_slaves_active_tbl[] = { 165 { "off", 0, BOND_VALFLAG_DEFAULT}, 166 { "on", 1, 0}, 167 { NULL, -1, 0} 168}; 169 170static const struct bond_opt_value bond_resend_igmp_tbl[] = { 171 { "off", 0, 0}, 172 { "maxval", 255, BOND_VALFLAG_MAX}, 173 { "default", 1, BOND_VALFLAG_DEFAULT}, 174 { NULL, -1, 0} 175}; 176 177static const struct bond_opt_value bond_lp_interval_tbl[] = { 178 { "minval", 1, BOND_VALFLAG_MIN | BOND_VALFLAG_DEFAULT}, 179 { "maxval", INT_MAX, BOND_VALFLAG_MAX}, 180 { NULL, -1, 0}, 181}; 182 183static const struct bond_opt_value bond_tlb_dynamic_lb_tbl[] = { 184 { "off", 0, 0}, 185 { "on", 1, BOND_VALFLAG_DEFAULT}, 186 { NULL, -1, 0} 187}; 188 189static const struct bond_option bond_opts[BOND_OPT_LAST] = { 190 [BOND_OPT_MODE] = { 191 .id = BOND_OPT_MODE, 192 .name = "mode", 193 .desc = "bond device mode", 194 .flags = BOND_OPTFLAG_NOSLAVES | BOND_OPTFLAG_IFDOWN, 195 .values = bond_mode_tbl, 196 .set = bond_option_mode_set 197 }, 198 [BOND_OPT_PACKETS_PER_SLAVE] = { 199 .id = BOND_OPT_PACKETS_PER_SLAVE, 200 .name = "packets_per_slave", 201 .desc = "Packets to send per slave in RR mode", 202 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ROUNDROBIN)), 203 .values = bond_pps_tbl, 204 .set = bond_option_pps_set 205 }, 206 [BOND_OPT_XMIT_HASH] = { 207 .id = BOND_OPT_XMIT_HASH, 208 .name = "xmit_hash_policy", 209 .desc = "balance-xor, 802.3ad, and tlb hashing method", 210 .values = bond_xmit_hashtype_tbl, 211 .set = bond_option_xmit_hash_policy_set 212 }, 213 [BOND_OPT_ARP_VALIDATE] = { 214 .id = BOND_OPT_ARP_VALIDATE, 215 .name = "arp_validate", 216 .desc = "validate src/dst of ARP probes", 217 .unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) | 218 BIT(BOND_MODE_ALB), 219 .values = bond_arp_validate_tbl, 220 .set = bond_option_arp_validate_set 221 }, 222 [BOND_OPT_ARP_ALL_TARGETS] = { 223 .id = BOND_OPT_ARP_ALL_TARGETS, 224 .name = "arp_all_targets", 225 .desc = "fail on any/all arp targets timeout", 226 .values = bond_arp_all_targets_tbl, 227 .set = bond_option_arp_all_targets_set 228 }, 229 [BOND_OPT_FAIL_OVER_MAC] = { 230 .id = BOND_OPT_FAIL_OVER_MAC, 231 .name = "fail_over_mac", 232 .desc = "For active-backup, do not set all slaves to the same MAC", 233 .flags = BOND_OPTFLAG_NOSLAVES, 234 .values = bond_fail_over_mac_tbl, 235 .set = bond_option_fail_over_mac_set 236 }, 237 [BOND_OPT_ARP_INTERVAL] = { 238 .id = BOND_OPT_ARP_INTERVAL, 239 .name = "arp_interval", 240 .desc = "arp interval in milliseconds", 241 .unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) | 242 BIT(BOND_MODE_ALB), 243 .values = bond_intmax_tbl, 244 .set = bond_option_arp_interval_set 245 }, 246 [BOND_OPT_ARP_TARGETS] = { 247 .id = BOND_OPT_ARP_TARGETS, 248 .name = "arp_ip_target", 249 .desc = "arp targets in n.n.n.n form", 250 .flags = BOND_OPTFLAG_RAWVAL, 251 .set = bond_option_arp_ip_targets_set 252 }, 253 [BOND_OPT_DOWNDELAY] = { 254 .id = BOND_OPT_DOWNDELAY, 255 .name = "downdelay", 256 .desc = "Delay before considering link down, in milliseconds", 257 .values = bond_intmax_tbl, 258 .set = bond_option_downdelay_set 259 }, 260 [BOND_OPT_UPDELAY] = { 261 .id = BOND_OPT_UPDELAY, 262 .name = "updelay", 263 .desc = "Delay before considering link up, in milliseconds", 264 .values = bond_intmax_tbl, 265 .set = bond_option_updelay_set 266 }, 267 [BOND_OPT_LACP_RATE] = { 268 .id = BOND_OPT_LACP_RATE, 269 .name = "lacp_rate", 270 .desc = "LACPDU tx rate to request from 802.3ad partner", 271 .flags = BOND_OPTFLAG_IFDOWN, 272 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)), 273 .values = bond_lacp_rate_tbl, 274 .set = bond_option_lacp_rate_set 275 }, 276 [BOND_OPT_MINLINKS] = { 277 .id = BOND_OPT_MINLINKS, 278 .name = "min_links", 279 .desc = "Minimum number of available links before turning on carrier", 280 .values = bond_intmax_tbl, 281 .set = bond_option_min_links_set 282 }, 283 [BOND_OPT_AD_SELECT] = { 284 .id = BOND_OPT_AD_SELECT, 285 .name = "ad_select", 286 .desc = "803.ad aggregation selection logic", 287 .flags = BOND_OPTFLAG_IFDOWN, 288 .values = bond_ad_select_tbl, 289 .set = bond_option_ad_select_set 290 }, 291 [BOND_OPT_NUM_PEER_NOTIF] = { 292 .id = BOND_OPT_NUM_PEER_NOTIF, 293 .name = "num_unsol_na", 294 .desc = "Number of peer notifications to send on failover event", 295 .values = bond_num_peer_notif_tbl, 296 .set = bond_option_num_peer_notif_set 297 }, 298 [BOND_OPT_MIIMON] = { 299 .id = BOND_OPT_MIIMON, 300 .name = "miimon", 301 .desc = "Link check interval in milliseconds", 302 .values = bond_intmax_tbl, 303 .set = bond_option_miimon_set 304 }, 305 [BOND_OPT_PRIMARY] = { 306 .id = BOND_OPT_PRIMARY, 307 .name = "primary", 308 .desc = "Primary network device to use", 309 .flags = BOND_OPTFLAG_RAWVAL, 310 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) | 311 BIT(BOND_MODE_TLB) | 312 BIT(BOND_MODE_ALB)), 313 .set = bond_option_primary_set 314 }, 315 [BOND_OPT_PRIMARY_RESELECT] = { 316 .id = BOND_OPT_PRIMARY_RESELECT, 317 .name = "primary_reselect", 318 .desc = "Reselect primary slave once it comes up", 319 .values = bond_primary_reselect_tbl, 320 .set = bond_option_primary_reselect_set 321 }, 322 [BOND_OPT_USE_CARRIER] = { 323 .id = BOND_OPT_USE_CARRIER, 324 .name = "use_carrier", 325 .desc = "Use netif_carrier_ok (vs MII ioctls) in miimon", 326 .values = bond_use_carrier_tbl, 327 .set = bond_option_use_carrier_set 328 }, 329 [BOND_OPT_ACTIVE_SLAVE] = { 330 .id = BOND_OPT_ACTIVE_SLAVE, 331 .name = "active_slave", 332 .desc = "Currently active slave", 333 .flags = BOND_OPTFLAG_RAWVAL, 334 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) | 335 BIT(BOND_MODE_TLB) | 336 BIT(BOND_MODE_ALB)), 337 .set = bond_option_active_slave_set 338 }, 339 [BOND_OPT_QUEUE_ID] = { 340 .id = BOND_OPT_QUEUE_ID, 341 .name = "queue_id", 342 .desc = "Set queue id of a slave", 343 .flags = BOND_OPTFLAG_RAWVAL, 344 .set = bond_option_queue_id_set 345 }, 346 [BOND_OPT_ALL_SLAVES_ACTIVE] = { 347 .id = BOND_OPT_ALL_SLAVES_ACTIVE, 348 .name = "all_slaves_active", 349 .desc = "Keep all frames received on an interface by setting active flag for all slaves", 350 .values = bond_all_slaves_active_tbl, 351 .set = bond_option_all_slaves_active_set 352 }, 353 [BOND_OPT_RESEND_IGMP] = { 354 .id = BOND_OPT_RESEND_IGMP, 355 .name = "resend_igmp", 356 .desc = "Number of IGMP membership reports to send on link failure", 357 .values = bond_resend_igmp_tbl, 358 .set = bond_option_resend_igmp_set 359 }, 360 [BOND_OPT_LP_INTERVAL] = { 361 .id = BOND_OPT_LP_INTERVAL, 362 .name = "lp_interval", 363 .desc = "The number of seconds between instances where the bonding driver sends learning packets to each slave's peer switch", 364 .values = bond_lp_interval_tbl, 365 .set = bond_option_lp_interval_set 366 }, 367 [BOND_OPT_SLAVES] = { 368 .id = BOND_OPT_SLAVES, 369 .name = "slaves", 370 .desc = "Slave membership management", 371 .flags = BOND_OPTFLAG_RAWVAL, 372 .set = bond_option_slaves_set 373 }, 374 [BOND_OPT_TLB_DYNAMIC_LB] = { 375 .id = BOND_OPT_TLB_DYNAMIC_LB, 376 .name = "tlb_dynamic_lb", 377 .desc = "Enable dynamic flow shuffling", 378 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_TLB)), 379 .values = bond_tlb_dynamic_lb_tbl, 380 .flags = BOND_OPTFLAG_IFDOWN, 381 .set = bond_option_tlb_dynamic_lb_set, 382 } 383}; 384 385/* Searches for an option by name */ 386const struct bond_option *bond_opt_get_by_name(const char *name) 387{ 388 const struct bond_option *opt; 389 int option; 390 391 for (option = 0; option < BOND_OPT_LAST; option++) { 392 opt = bond_opt_get(option); 393 if (opt && !strcmp(opt->name, name)) 394 return opt; 395 } 396 397 return NULL; 398} 399 400/* Searches for a value in opt's values[] table */ 401const struct bond_opt_value *bond_opt_get_val(unsigned int option, u64 val) 402{ 403 const struct bond_option *opt; 404 int i; 405 406 opt = bond_opt_get(option); 407 if (WARN_ON(!opt)) 408 return NULL; 409 for (i = 0; opt->values && opt->values[i].string; i++) 410 if (opt->values[i].value == val) 411 return &opt->values[i]; 412 413 return NULL; 414} 415 416/* Searches for a value in opt's values[] table which matches the flagmask */ 417static const struct bond_opt_value *bond_opt_get_flags(const struct bond_option *opt, 418 u32 flagmask) 419{ 420 int i; 421 422 for (i = 0; opt->values && opt->values[i].string; i++) 423 if (opt->values[i].flags & flagmask) 424 return &opt->values[i]; 425 426 return NULL; 427} 428 429/* If maxval is missing then there's no range to check. In case minval is 430 * missing then it's considered to be 0. 431 */ 432static bool bond_opt_check_range(const struct bond_option *opt, u64 val) 433{ 434 const struct bond_opt_value *minval, *maxval; 435 436 minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN); 437 maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX); 438 if (!maxval || (minval && val < minval->value) || val > maxval->value) 439 return false; 440 441 return true; 442} 443 444/** 445 * bond_opt_parse - parse option value 446 * @opt: the option to parse against 447 * @val: value to parse 448 * 449 * This function tries to extract the value from @val and check if it's 450 * a possible match for the option and returns NULL if a match isn't found, 451 * or the struct_opt_value that matched. It also strips the new line from 452 * @val->string if it's present. 453 */ 454const struct bond_opt_value *bond_opt_parse(const struct bond_option *opt, 455 struct bond_opt_value *val) 456{ 457 char *p, valstr[BOND_OPT_MAX_NAMELEN + 1] = { 0, }; 458 const struct bond_opt_value *tbl; 459 const struct bond_opt_value *ret = NULL; 460 bool checkval; 461 int i, rv; 462 463 /* No parsing if the option wants a raw val */ 464 if (opt->flags & BOND_OPTFLAG_RAWVAL) 465 return val; 466 467 tbl = opt->values; 468 if (!tbl) 469 goto out; 470 471 /* ULLONG_MAX is used to bypass string processing */ 472 checkval = val->value != ULLONG_MAX; 473 if (!checkval) { 474 if (!val->string) 475 goto out; 476 p = strchr(val->string, '\n'); 477 if (p) 478 *p = '\0'; 479 for (p = val->string; *p; p++) 480 if (!(isdigit(*p) || isspace(*p))) 481 break; 482 /* The following code extracts the string to match or the value 483 * and sets checkval appropriately 484 */ 485 if (*p) { 486 rv = sscanf(val->string, "%32s", valstr); 487 } else { 488 rv = sscanf(val->string, "%llu", &val->value); 489 checkval = true; 490 } 491 if (!rv) 492 goto out; 493 } 494 495 for (i = 0; tbl[i].string; i++) { 496 /* Check for exact match */ 497 if (checkval) { 498 if (val->value == tbl[i].value) 499 ret = &tbl[i]; 500 } else { 501 if (!strcmp(valstr, "default") && 502 (tbl[i].flags & BOND_VALFLAG_DEFAULT)) 503 ret = &tbl[i]; 504 505 if (!strcmp(valstr, tbl[i].string)) 506 ret = &tbl[i]; 507 } 508 /* Found an exact match */ 509 if (ret) 510 goto out; 511 } 512 /* Possible range match */ 513 if (checkval && bond_opt_check_range(opt, val->value)) 514 ret = val; 515out: 516 return ret; 517} 518 519/* Check opt's dependencies against bond mode and currently set options */ 520static int bond_opt_check_deps(struct bonding *bond, 521 const struct bond_option *opt) 522{ 523 struct bond_params *params = &bond->params; 524 525 if (test_bit(params->mode, &opt->unsuppmodes)) 526 return -EACCES; 527 if ((opt->flags & BOND_OPTFLAG_NOSLAVES) && bond_has_slaves(bond)) 528 return -ENOTEMPTY; 529 if ((opt->flags & BOND_OPTFLAG_IFDOWN) && (bond->dev->flags & IFF_UP)) 530 return -EBUSY; 531 532 return 0; 533} 534 535static void bond_opt_dep_print(struct bonding *bond, 536 const struct bond_option *opt) 537{ 538 const struct bond_opt_value *modeval; 539 struct bond_params *params; 540 541 params = &bond->params; 542 modeval = bond_opt_get_val(BOND_OPT_MODE, params->mode); 543 if (test_bit(params->mode, &opt->unsuppmodes)) 544 netdev_err(bond->dev, "option %s: mode dependency failed, not supported in mode %s(%llu)\n", 545 opt->name, modeval->string, modeval->value); 546} 547 548static void bond_opt_error_interpret(struct bonding *bond, 549 const struct bond_option *opt, 550 int error, const struct bond_opt_value *val) 551{ 552 const struct bond_opt_value *minval, *maxval; 553 char *p; 554 555 switch (error) { 556 case -EINVAL: 557 if (val) { 558 if (val->string) { 559 /* sometimes RAWVAL opts may have new lines */ 560 p = strchr(val->string, '\n'); 561 if (p) 562 *p = '\0'; 563 netdev_err(bond->dev, "option %s: invalid value (%s)\n", 564 opt->name, val->string); 565 } else { 566 netdev_err(bond->dev, "option %s: invalid value (%llu)\n", 567 opt->name, val->value); 568 } 569 } 570 minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN); 571 maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX); 572 if (!maxval) 573 break; 574 netdev_err(bond->dev, "option %s: allowed values %llu - %llu\n", 575 opt->name, minval ? minval->value : 0, maxval->value); 576 break; 577 case -EACCES: 578 bond_opt_dep_print(bond, opt); 579 break; 580 case -ENOTEMPTY: 581 netdev_err(bond->dev, "option %s: unable to set because the bond device has slaves\n", 582 opt->name); 583 break; 584 case -EBUSY: 585 netdev_err(bond->dev, "option %s: unable to set because the bond device is up\n", 586 opt->name); 587 break; 588 default: 589 break; 590 } 591} 592 593/** 594 * __bond_opt_set - set a bonding option 595 * @bond: target bond device 596 * @option: option to set 597 * @val: value to set it to 598 * 599 * This function is used to change the bond's option value, it can be 600 * used for both enabling/changing an option and for disabling it. RTNL lock 601 * must be obtained before calling this function. 602 */ 603int __bond_opt_set(struct bonding *bond, 604 unsigned int option, struct bond_opt_value *val) 605{ 606 const struct bond_opt_value *retval = NULL; 607 const struct bond_option *opt; 608 int ret = -ENOENT; 609 610 ASSERT_RTNL(); 611 612 opt = bond_opt_get(option); 613 if (WARN_ON(!val) || WARN_ON(!opt)) 614 goto out; 615 ret = bond_opt_check_deps(bond, opt); 616 if (ret) 617 goto out; 618 retval = bond_opt_parse(opt, val); 619 if (!retval) { 620 ret = -EINVAL; 621 goto out; 622 } 623 ret = opt->set(bond, retval); 624out: 625 if (ret) 626 bond_opt_error_interpret(bond, opt, ret, val); 627 else if (bond->dev->reg_state == NETREG_REGISTERED) 628 call_netdevice_notifiers(NETDEV_CHANGEINFODATA, bond->dev); 629 630 return ret; 631} 632 633/** 634 * bond_opt_tryset_rtnl - try to acquire rtnl and call __bond_opt_set 635 * @bond: target bond device 636 * @option: option to set 637 * @buf: value to set it to 638 * 639 * This function tries to acquire RTNL without blocking and if successful 640 * calls __bond_opt_set. It is mainly used for sysfs option manipulation. 641 */ 642int bond_opt_tryset_rtnl(struct bonding *bond, unsigned int option, char *buf) 643{ 644 struct bond_opt_value optval; 645 int ret; 646 647 if (!rtnl_trylock()) 648 return restart_syscall(); 649 bond_opt_initstr(&optval, buf); 650 ret = __bond_opt_set(bond, option, &optval); 651 rtnl_unlock(); 652 653 return ret; 654} 655 656/** 657 * bond_opt_get - get a pointer to an option 658 * @option: option for which to return a pointer 659 * 660 * This function checks if option is valid and if so returns a pointer 661 * to its entry in the bond_opts[] option array. 662 */ 663const struct bond_option *bond_opt_get(unsigned int option) 664{ 665 if (!BOND_OPT_VALID(option)) 666 return NULL; 667 668 return &bond_opts[option]; 669} 670 671static int bond_option_mode_set(struct bonding *bond, 672 const struct bond_opt_value *newval) 673{ 674 if (!bond_mode_uses_arp(newval->value) && bond->params.arp_interval) { 675 netdev_info(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n", 676 newval->string); 677 /* disable arp monitoring */ 678 bond->params.arp_interval = 0; 679 /* set miimon to default value */ 680 bond->params.miimon = BOND_DEFAULT_MIIMON; 681 netdev_info(bond->dev, "Setting MII monitoring interval to %d\n", 682 bond->params.miimon); 683 } 684 685 /* don't cache arp_validate between modes */ 686 bond->params.arp_validate = BOND_ARP_VALIDATE_NONE; 687 bond->params.mode = newval->value; 688 689 return 0; 690} 691 692static struct net_device *__bond_option_active_slave_get(struct bonding *bond, 693 struct slave *slave) 694{ 695 return bond_uses_primary(bond) && slave ? slave->dev : NULL; 696} 697 698struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond) 699{ 700 struct slave *slave = rcu_dereference(bond->curr_active_slave); 701 702 return __bond_option_active_slave_get(bond, slave); 703} 704 705static int bond_option_active_slave_set(struct bonding *bond, 706 const struct bond_opt_value *newval) 707{ 708 char ifname[IFNAMSIZ] = { 0, }; 709 struct net_device *slave_dev; 710 int ret = 0; 711 712 sscanf(newval->string, "%15s", ifname); /* IFNAMSIZ */ 713 if (!strlen(ifname) || newval->string[0] == '\n') { 714 slave_dev = NULL; 715 } else { 716 slave_dev = __dev_get_by_name(dev_net(bond->dev), ifname); 717 if (!slave_dev) 718 return -ENODEV; 719 } 720 721 if (slave_dev) { 722 if (!netif_is_bond_slave(slave_dev)) { 723 netdev_err(bond->dev, "Device %s is not bonding slave\n", 724 slave_dev->name); 725 return -EINVAL; 726 } 727 728 if (bond->dev != netdev_master_upper_dev_get(slave_dev)) { 729 netdev_err(bond->dev, "Device %s is not our slave\n", 730 slave_dev->name); 731 return -EINVAL; 732 } 733 } 734 735 block_netpoll_tx(); 736 /* check to see if we are clearing active */ 737 if (!slave_dev) { 738 netdev_info(bond->dev, "Clearing current active slave\n"); 739 RCU_INIT_POINTER(bond->curr_active_slave, NULL); 740 bond_select_active_slave(bond); 741 } else { 742 struct slave *old_active = rtnl_dereference(bond->curr_active_slave); 743 struct slave *new_active = bond_slave_get_rtnl(slave_dev); 744 745 BUG_ON(!new_active); 746 747 if (new_active == old_active) { 748 /* do nothing */ 749 netdev_info(bond->dev, "%s is already the current active slave\n", 750 new_active->dev->name); 751 } else { 752 if (old_active && (new_active->link == BOND_LINK_UP) && 753 bond_slave_is_up(new_active)) { 754 netdev_info(bond->dev, "Setting %s as active slave\n", 755 new_active->dev->name); 756 bond_change_active_slave(bond, new_active); 757 } else { 758 netdev_err(bond->dev, "Could not set %s as active slave; either %s is down or the link is down\n", 759 new_active->dev->name, 760 new_active->dev->name); 761 ret = -EINVAL; 762 } 763 } 764 } 765 unblock_netpoll_tx(); 766 767 return ret; 768} 769 770/* There are two tricky bits here. First, if MII monitoring is activated, then 771 * we must disable ARP monitoring. Second, if the timer isn't running, we must 772 * start it. 773 */ 774static int bond_option_miimon_set(struct bonding *bond, 775 const struct bond_opt_value *newval) 776{ 777 netdev_info(bond->dev, "Setting MII monitoring interval to %llu\n", 778 newval->value); 779 bond->params.miimon = newval->value; 780 if (bond->params.updelay) 781 netdev_info(bond->dev, "Note: Updating updelay (to %d) since it is a multiple of the miimon value\n", 782 bond->params.updelay * bond->params.miimon); 783 if (bond->params.downdelay) 784 netdev_info(bond->dev, "Note: Updating downdelay (to %d) since it is a multiple of the miimon value\n", 785 bond->params.downdelay * bond->params.miimon); 786 if (newval->value && bond->params.arp_interval) { 787 netdev_info(bond->dev, "MII monitoring cannot be used with ARP monitoring - disabling ARP monitoring...\n"); 788 bond->params.arp_interval = 0; 789 if (bond->params.arp_validate) 790 bond->params.arp_validate = BOND_ARP_VALIDATE_NONE; 791 } 792 if (bond->dev->flags & IFF_UP) { 793 /* If the interface is up, we may need to fire off 794 * the MII timer. If the interface is down, the 795 * timer will get fired off when the open function 796 * is called. 797 */ 798 if (!newval->value) { 799 cancel_delayed_work_sync(&bond->mii_work); 800 } else { 801 cancel_delayed_work_sync(&bond->arp_work); 802 queue_delayed_work(bond->wq, &bond->mii_work, 0); 803 } 804 } 805 806 return 0; 807} 808 809/* Set up and down delays. These must be multiples of the 810 * MII monitoring value, and are stored internally as the multiplier. 811 * Thus, we must translate to MS for the real world. 812 */ 813static int bond_option_updelay_set(struct bonding *bond, 814 const struct bond_opt_value *newval) 815{ 816 int value = newval->value; 817 818 if (!bond->params.miimon) { 819 netdev_err(bond->dev, "Unable to set up delay as MII monitoring is disabled\n"); 820 return -EPERM; 821 } 822 if ((value % bond->params.miimon) != 0) { 823 netdev_warn(bond->dev, "up delay (%d) is not a multiple of miimon (%d), updelay rounded to %d ms\n", 824 value, bond->params.miimon, 825 (value / bond->params.miimon) * 826 bond->params.miimon); 827 } 828 bond->params.updelay = value / bond->params.miimon; 829 netdev_info(bond->dev, "Setting up delay to %d\n", 830 bond->params.updelay * bond->params.miimon); 831 832 return 0; 833} 834 835static int bond_option_downdelay_set(struct bonding *bond, 836 const struct bond_opt_value *newval) 837{ 838 int value = newval->value; 839 840 if (!bond->params.miimon) { 841 netdev_err(bond->dev, "Unable to set down delay as MII monitoring is disabled\n"); 842 return -EPERM; 843 } 844 if ((value % bond->params.miimon) != 0) { 845 netdev_warn(bond->dev, "down delay (%d) is not a multiple of miimon (%d), delay rounded to %d ms\n", 846 value, bond->params.miimon, 847 (value / bond->params.miimon) * 848 bond->params.miimon); 849 } 850 bond->params.downdelay = value / bond->params.miimon; 851 netdev_info(bond->dev, "Setting down delay to %d\n", 852 bond->params.downdelay * bond->params.miimon); 853 854 return 0; 855} 856 857static int bond_option_use_carrier_set(struct bonding *bond, 858 const struct bond_opt_value *newval) 859{ 860 netdev_info(bond->dev, "Setting use_carrier to %llu\n", 861 newval->value); 862 bond->params.use_carrier = newval->value; 863 864 return 0; 865} 866 867/* There are two tricky bits here. First, if ARP monitoring is activated, then 868 * we must disable MII monitoring. Second, if the ARP timer isn't running, 869 * we must start it. 870 */ 871static int bond_option_arp_interval_set(struct bonding *bond, 872 const struct bond_opt_value *newval) 873{ 874 netdev_info(bond->dev, "Setting ARP monitoring interval to %llu\n", 875 newval->value); 876 bond->params.arp_interval = newval->value; 877 if (newval->value) { 878 if (bond->params.miimon) { 879 netdev_info(bond->dev, "ARP monitoring cannot be used with MII monitoring. Disabling MII monitoring\n"); 880 bond->params.miimon = 0; 881 } 882 if (!bond->params.arp_targets[0]) 883 netdev_info(bond->dev, "ARP monitoring has been set up, but no ARP targets have been specified\n"); 884 } 885 if (bond->dev->flags & IFF_UP) { 886 /* If the interface is up, we may need to fire off 887 * the ARP timer. If the interface is down, the 888 * timer will get fired off when the open function 889 * is called. 890 */ 891 if (!newval->value) { 892 if (bond->params.arp_validate) 893 bond->recv_probe = NULL; 894 cancel_delayed_work_sync(&bond->arp_work); 895 } else { 896 /* arp_validate can be set only in active-backup mode */ 897 bond->recv_probe = bond_arp_rcv; 898 cancel_delayed_work_sync(&bond->mii_work); 899 queue_delayed_work(bond->wq, &bond->arp_work, 0); 900 } 901 } 902 903 return 0; 904} 905 906static void _bond_options_arp_ip_target_set(struct bonding *bond, int slot, 907 __be32 target, 908 unsigned long last_rx) 909{ 910 __be32 *targets = bond->params.arp_targets; 911 struct list_head *iter; 912 struct slave *slave; 913 914 if (slot >= 0 && slot < BOND_MAX_ARP_TARGETS) { 915 bond_for_each_slave(bond, slave, iter) 916 slave->target_last_arp_rx[slot] = last_rx; 917 targets[slot] = target; 918 } 919} 920 921static int _bond_option_arp_ip_target_add(struct bonding *bond, __be32 target) 922{ 923 __be32 *targets = bond->params.arp_targets; 924 int ind; 925 926 if (!bond_is_ip_target_ok(target)) { 927 netdev_err(bond->dev, "invalid ARP target %pI4 specified for addition\n", 928 &target); 929 return -EINVAL; 930 } 931 932 if (bond_get_targets_ip(targets, target) != -1) { /* dup */ 933 netdev_err(bond->dev, "ARP target %pI4 is already present\n", 934 &target); 935 return -EINVAL; 936 } 937 938 ind = bond_get_targets_ip(targets, 0); /* first free slot */ 939 if (ind == -1) { 940 netdev_err(bond->dev, "ARP target table is full!\n"); 941 return -EINVAL; 942 } 943 944 netdev_info(bond->dev, "Adding ARP target %pI4\n", &target); 945 946 _bond_options_arp_ip_target_set(bond, ind, target, jiffies); 947 948 return 0; 949} 950 951static int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target) 952{ 953 return _bond_option_arp_ip_target_add(bond, target); 954} 955 956static int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target) 957{ 958 __be32 *targets = bond->params.arp_targets; 959 struct list_head *iter; 960 struct slave *slave; 961 unsigned long *targets_rx; 962 int ind, i; 963 964 if (!bond_is_ip_target_ok(target)) { 965 netdev_err(bond->dev, "invalid ARP target %pI4 specified for removal\n", 966 &target); 967 return -EINVAL; 968 } 969 970 ind = bond_get_targets_ip(targets, target); 971 if (ind == -1) { 972 netdev_err(bond->dev, "unable to remove nonexistent ARP target %pI4\n", 973 &target); 974 return -EINVAL; 975 } 976 977 if (ind == 0 && !targets[1] && bond->params.arp_interval) 978 netdev_warn(bond->dev, "Removing last arp target with arp_interval on\n"); 979 980 netdev_info(bond->dev, "Removing ARP target %pI4\n", &target); 981 982 bond_for_each_slave(bond, slave, iter) { 983 targets_rx = slave->target_last_arp_rx; 984 for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++) 985 targets_rx[i] = targets_rx[i+1]; 986 targets_rx[i] = 0; 987 } 988 for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++) 989 targets[i] = targets[i+1]; 990 targets[i] = 0; 991 992 return 0; 993} 994 995void bond_option_arp_ip_targets_clear(struct bonding *bond) 996{ 997 int i; 998 999 for (i = 0; i < BOND_MAX_ARP_TARGETS; i++) 1000 _bond_options_arp_ip_target_set(bond, i, 0, 0); 1001} 1002 1003static int bond_option_arp_ip_targets_set(struct bonding *bond, 1004 const struct bond_opt_value *newval) 1005{ 1006 int ret = -EPERM; 1007 __be32 target; 1008 1009 if (newval->string) { 1010 if (!in4_pton(newval->string+1, -1, (u8 *)&target, -1, NULL)) { 1011 netdev_err(bond->dev, "invalid ARP target %pI4 specified\n", 1012 &target); 1013 return ret; 1014 } 1015 if (newval->string[0] == '+') 1016 ret = bond_option_arp_ip_target_add(bond, target); 1017 else if (newval->string[0] == '-') 1018 ret = bond_option_arp_ip_target_rem(bond, target); 1019 else 1020 netdev_err(bond->dev, "no command found in arp_ip_targets file - use +<addr> or -<addr>\n"); 1021 } else { 1022 target = newval->value; 1023 ret = bond_option_arp_ip_target_add(bond, target); 1024 } 1025 1026 return ret; 1027} 1028 1029static int bond_option_arp_validate_set(struct bonding *bond, 1030 const struct bond_opt_value *newval) 1031{ 1032 netdev_info(bond->dev, "Setting arp_validate to %s (%llu)\n", 1033 newval->string, newval->value); 1034 1035 if (bond->dev->flags & IFF_UP) { 1036 if (!newval->value) 1037 bond->recv_probe = NULL; 1038 else if (bond->params.arp_interval) 1039 bond->recv_probe = bond_arp_rcv; 1040 } 1041 bond->params.arp_validate = newval->value; 1042 1043 return 0; 1044} 1045 1046static int bond_option_arp_all_targets_set(struct bonding *bond, 1047 const struct bond_opt_value *newval) 1048{ 1049 netdev_info(bond->dev, "Setting arp_all_targets to %s (%llu)\n", 1050 newval->string, newval->value); 1051 bond->params.arp_all_targets = newval->value; 1052 1053 return 0; 1054} 1055 1056static int bond_option_primary_set(struct bonding *bond, 1057 const struct bond_opt_value *newval) 1058{ 1059 char *p, *primary = newval->string; 1060 struct list_head *iter; 1061 struct slave *slave; 1062 1063 block_netpoll_tx(); 1064 1065 p = strchr(primary, '\n'); 1066 if (p) 1067 *p = '\0'; 1068 /* check to see if we are clearing primary */ 1069 if (!strlen(primary)) { 1070 netdev_info(bond->dev, "Setting primary slave to None\n"); 1071 RCU_INIT_POINTER(bond->primary_slave, NULL); 1072 memset(bond->params.primary, 0, sizeof(bond->params.primary)); 1073 bond_select_active_slave(bond); 1074 goto out; 1075 } 1076 1077 bond_for_each_slave(bond, slave, iter) { 1078 if (strncmp(slave->dev->name, primary, IFNAMSIZ) == 0) { 1079 netdev_info(bond->dev, "Setting %s as primary slave\n", 1080 slave->dev->name); 1081 rcu_assign_pointer(bond->primary_slave, slave); 1082 strcpy(bond->params.primary, slave->dev->name); 1083 bond_select_active_slave(bond); 1084 goto out; 1085 } 1086 } 1087 1088 if (rtnl_dereference(bond->primary_slave)) { 1089 netdev_info(bond->dev, "Setting primary slave to None\n"); 1090 RCU_INIT_POINTER(bond->primary_slave, NULL); 1091 bond_select_active_slave(bond); 1092 } 1093 strncpy(bond->params.primary, primary, IFNAMSIZ); 1094 bond->params.primary[IFNAMSIZ - 1] = 0; 1095 1096 netdev_info(bond->dev, "Recording %s as primary, but it has not been enslaved to %s yet\n", 1097 primary, bond->dev->name); 1098 1099out: 1100 unblock_netpoll_tx(); 1101 1102 return 0; 1103} 1104 1105static int bond_option_primary_reselect_set(struct bonding *bond, 1106 const struct bond_opt_value *newval) 1107{ 1108 netdev_info(bond->dev, "Setting primary_reselect to %s (%llu)\n", 1109 newval->string, newval->value); 1110 bond->params.primary_reselect = newval->value; 1111 1112 block_netpoll_tx(); 1113 bond_select_active_slave(bond); 1114 unblock_netpoll_tx(); 1115 1116 return 0; 1117} 1118 1119static int bond_option_fail_over_mac_set(struct bonding *bond, 1120 const struct bond_opt_value *newval) 1121{ 1122 netdev_info(bond->dev, "Setting fail_over_mac to %s (%llu)\n", 1123 newval->string, newval->value); 1124 bond->params.fail_over_mac = newval->value; 1125 1126 return 0; 1127} 1128 1129static int bond_option_xmit_hash_policy_set(struct bonding *bond, 1130 const struct bond_opt_value *newval) 1131{ 1132 netdev_info(bond->dev, "Setting xmit hash policy to %s (%llu)\n", 1133 newval->string, newval->value); 1134 bond->params.xmit_policy = newval->value; 1135 1136 return 0; 1137} 1138 1139static int bond_option_resend_igmp_set(struct bonding *bond, 1140 const struct bond_opt_value *newval) 1141{ 1142 netdev_info(bond->dev, "Setting resend_igmp to %llu\n", 1143 newval->value); 1144 bond->params.resend_igmp = newval->value; 1145 1146 return 0; 1147} 1148 1149static int bond_option_num_peer_notif_set(struct bonding *bond, 1150 const struct bond_opt_value *newval) 1151{ 1152 bond->params.num_peer_notif = newval->value; 1153 1154 return 0; 1155} 1156 1157static int bond_option_all_slaves_active_set(struct bonding *bond, 1158 const struct bond_opt_value *newval) 1159{ 1160 struct list_head *iter; 1161 struct slave *slave; 1162 1163 if (newval->value == bond->params.all_slaves_active) 1164 return 0; 1165 bond->params.all_slaves_active = newval->value; 1166 bond_for_each_slave(bond, slave, iter) { 1167 if (!bond_is_active_slave(slave)) { 1168 if (newval->value) 1169 slave->inactive = 0; 1170 else 1171 slave->inactive = 1; 1172 } 1173 } 1174 1175 return 0; 1176} 1177 1178static int bond_option_min_links_set(struct bonding *bond, 1179 const struct bond_opt_value *newval) 1180{ 1181 netdev_info(bond->dev, "Setting min links value to %llu\n", 1182 newval->value); 1183 bond->params.min_links = newval->value; 1184 bond_set_carrier(bond); 1185 1186 return 0; 1187} 1188 1189static int bond_option_lp_interval_set(struct bonding *bond, 1190 const struct bond_opt_value *newval) 1191{ 1192 bond->params.lp_interval = newval->value; 1193 1194 return 0; 1195} 1196 1197static int bond_option_pps_set(struct bonding *bond, 1198 const struct bond_opt_value *newval) 1199{ 1200 bond->params.packets_per_slave = newval->value; 1201 if (newval->value > 0) { 1202 bond->params.reciprocal_packets_per_slave = 1203 reciprocal_value(newval->value); 1204 } else { 1205 /* reciprocal_packets_per_slave is unused if 1206 * packets_per_slave is 0 or 1, just initialize it 1207 */ 1208 bond->params.reciprocal_packets_per_slave = 1209 (struct reciprocal_value) { 0 }; 1210 } 1211 1212 return 0; 1213} 1214 1215static int bond_option_lacp_rate_set(struct bonding *bond, 1216 const struct bond_opt_value *newval) 1217{ 1218 netdev_info(bond->dev, "Setting LACP rate to %s (%llu)\n", 1219 newval->string, newval->value); 1220 bond->params.lacp_fast = newval->value; 1221 bond_3ad_update_lacp_rate(bond); 1222 1223 return 0; 1224} 1225 1226static int bond_option_ad_select_set(struct bonding *bond, 1227 const struct bond_opt_value *newval) 1228{ 1229 netdev_info(bond->dev, "Setting ad_select to %s (%llu)\n", 1230 newval->string, newval->value); 1231 bond->params.ad_select = newval->value; 1232 1233 return 0; 1234} 1235 1236static int bond_option_queue_id_set(struct bonding *bond, 1237 const struct bond_opt_value *newval) 1238{ 1239 struct slave *slave, *update_slave; 1240 struct net_device *sdev; 1241 struct list_head *iter; 1242 char *delim; 1243 int ret = 0; 1244 u16 qid; 1245 1246 /* delim will point to queue id if successful */ 1247 delim = strchr(newval->string, ':'); 1248 if (!delim) 1249 goto err_no_cmd; 1250 1251 /* Terminate string that points to device name and bump it 1252 * up one, so we can read the queue id there. 1253 */ 1254 *delim = '\0'; 1255 if (sscanf(++delim, "%hd\n", &qid) != 1) 1256 goto err_no_cmd; 1257 1258 /* Check buffer length, valid ifname and queue id */ 1259 if (!dev_valid_name(newval->string) || 1260 qid > bond->dev->real_num_tx_queues) 1261 goto err_no_cmd; 1262 1263 /* Get the pointer to that interface if it exists */ 1264 sdev = __dev_get_by_name(dev_net(bond->dev), newval->string); 1265 if (!sdev) 1266 goto err_no_cmd; 1267 1268 /* Search for thes slave and check for duplicate qids */ 1269 update_slave = NULL; 1270 bond_for_each_slave(bond, slave, iter) { 1271 if (sdev == slave->dev) 1272 /* We don't need to check the matching 1273 * slave for dups, since we're overwriting it 1274 */ 1275 update_slave = slave; 1276 else if (qid && qid == slave->queue_id) { 1277 goto err_no_cmd; 1278 } 1279 } 1280 1281 if (!update_slave) 1282 goto err_no_cmd; 1283 1284 /* Actually set the qids for the slave */ 1285 update_slave->queue_id = qid; 1286 1287out: 1288 return ret; 1289 1290err_no_cmd: 1291 netdev_info(bond->dev, "invalid input for queue_id set\n"); 1292 ret = -EPERM; 1293 goto out; 1294 1295} 1296 1297static int bond_option_slaves_set(struct bonding *bond, 1298 const struct bond_opt_value *newval) 1299{ 1300 char command[IFNAMSIZ + 1] = { 0, }; 1301 struct net_device *dev; 1302 char *ifname; 1303 int ret; 1304 1305 sscanf(newval->string, "%16s", command); /* IFNAMSIZ*/ 1306 ifname = command + 1; 1307 if ((strlen(command) <= 1) || 1308 !dev_valid_name(ifname)) 1309 goto err_no_cmd; 1310 1311 dev = __dev_get_by_name(dev_net(bond->dev), ifname); 1312 if (!dev) { 1313 netdev_info(bond->dev, "interface %s does not exist!\n", 1314 ifname); 1315 ret = -ENODEV; 1316 goto out; 1317 } 1318 1319 switch (command[0]) { 1320 case '+': 1321 netdev_info(bond->dev, "Adding slave %s\n", dev->name); 1322 ret = bond_enslave(bond->dev, dev); 1323 break; 1324 1325 case '-': 1326 netdev_info(bond->dev, "Removing slave %s\n", dev->name); 1327 ret = bond_release(bond->dev, dev); 1328 break; 1329 1330 default: 1331 goto err_no_cmd; 1332 } 1333 1334out: 1335 return ret; 1336 1337err_no_cmd: 1338 netdev_err(bond->dev, "no command found in slaves file - use +ifname or -ifname\n"); 1339 ret = -EPERM; 1340 goto out; 1341} 1342 1343static int bond_option_tlb_dynamic_lb_set(struct bonding *bond, 1344 const struct bond_opt_value *newval) 1345{ 1346 netdev_info(bond->dev, "Setting dynamic-lb to %s (%llu)\n", 1347 newval->string, newval->value); 1348 bond->params.tlb_dynamic_lb = newval->value; 1349 1350 return 0; 1351} 1352