1 /*
2  * Copyright (c) 2014, The Linux Foundation. All rights reserved.
3  * Copyright (C) 2013 Red Hat
4  * Author: Rob Clark <robdclark@gmail.com>
5  *
6  * This program is free software; you can redistribute it and/or modify it
7  * under the terms of the GNU General Public License version 2 as published by
8  * the Free Software Foundation.
9  *
10  * This program is distributed in the hope that it will be useful, but WITHOUT
11  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
12  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
13  * more details.
14  *
15  * You should have received a copy of the GNU General Public License along with
16  * this program.  If not, see <http://www.gnu.org/licenses/>.
17  */
18 
19 
20 #include "msm_drv.h"
21 #include "msm_mmu.h"
22 #include "mdp5_kms.h"
23 
24 static const char *iommu_ports[] = {
25 		"mdp_0",
26 };
27 
mdp5_hw_init(struct msm_kms * kms)28 static int mdp5_hw_init(struct msm_kms *kms)
29 {
30 	struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms));
31 	struct drm_device *dev = mdp5_kms->dev;
32 	unsigned long flags;
33 
34 	pm_runtime_get_sync(dev->dev);
35 
36 	/* Magic unknown register writes:
37 	 *
38 	 *    W VBIF:0x004 00000001      (mdss_mdp.c:839)
39 	 *    W MDP5:0x2e0 0xe9          (mdss_mdp.c:839)
40 	 *    W MDP5:0x2e4 0x55          (mdss_mdp.c:839)
41 	 *    W MDP5:0x3ac 0xc0000ccc    (mdss_mdp.c:839)
42 	 *    W MDP5:0x3b4 0xc0000ccc    (mdss_mdp.c:839)
43 	 *    W MDP5:0x3bc 0xcccccc      (mdss_mdp.c:839)
44 	 *    W MDP5:0x4a8 0xcccc0c0     (mdss_mdp.c:839)
45 	 *    W MDP5:0x4b0 0xccccc0c0    (mdss_mdp.c:839)
46 	 *    W MDP5:0x4b8 0xccccc000    (mdss_mdp.c:839)
47 	 *
48 	 * Downstream fbdev driver gets these register offsets/values
49 	 * from DT.. not really sure what these registers are or if
50 	 * different values for different boards/SoC's, etc.  I guess
51 	 * they are the golden registers.
52 	 *
53 	 * Not setting these does not seem to cause any problem.  But
54 	 * we may be getting lucky with the bootloader initializing
55 	 * them for us.  OTOH, if we can always count on the bootloader
56 	 * setting the golden registers, then perhaps we don't need to
57 	 * care.
58 	 */
59 
60 	spin_lock_irqsave(&mdp5_kms->resource_lock, flags);
61 	mdp5_write(mdp5_kms, REG_MDP5_MDP_DISP_INTF_SEL(0), 0);
62 	spin_unlock_irqrestore(&mdp5_kms->resource_lock, flags);
63 
64 	mdp5_ctlm_hw_reset(mdp5_kms->ctlm);
65 
66 	pm_runtime_put_sync(dev->dev);
67 
68 	return 0;
69 }
70 
mdp5_prepare_commit(struct msm_kms * kms,struct drm_atomic_state * state)71 static void mdp5_prepare_commit(struct msm_kms *kms, struct drm_atomic_state *state)
72 {
73 	struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms));
74 	mdp5_enable(mdp5_kms);
75 }
76 
mdp5_complete_commit(struct msm_kms * kms,struct drm_atomic_state * state)77 static void mdp5_complete_commit(struct msm_kms *kms, struct drm_atomic_state *state)
78 {
79 	int i;
80 	struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms));
81 	int nplanes = mdp5_kms->dev->mode_config.num_total_plane;
82 
83 	for (i = 0; i < nplanes; i++) {
84 		struct drm_plane *plane = state->planes[i];
85 		struct drm_plane_state *plane_state = state->plane_states[i];
86 
87 		if (!plane)
88 			continue;
89 
90 		mdp5_plane_complete_commit(plane, plane_state);
91 	}
92 
93 	mdp5_disable(mdp5_kms);
94 }
95 
mdp5_wait_for_crtc_commit_done(struct msm_kms * kms,struct drm_crtc * crtc)96 static void mdp5_wait_for_crtc_commit_done(struct msm_kms *kms,
97 						struct drm_crtc *crtc)
98 {
99 	mdp5_crtc_wait_for_commit_done(crtc);
100 }
101 
mdp5_round_pixclk(struct msm_kms * kms,unsigned long rate,struct drm_encoder * encoder)102 static long mdp5_round_pixclk(struct msm_kms *kms, unsigned long rate,
103 		struct drm_encoder *encoder)
104 {
105 	return rate;
106 }
107 
mdp5_set_split_display(struct msm_kms * kms,struct drm_encoder * encoder,struct drm_encoder * slave_encoder,bool is_cmd_mode)108 static int mdp5_set_split_display(struct msm_kms *kms,
109 		struct drm_encoder *encoder,
110 		struct drm_encoder *slave_encoder,
111 		bool is_cmd_mode)
112 {
113 	if (is_cmd_mode)
114 		return mdp5_cmd_encoder_set_split_display(encoder,
115 							slave_encoder);
116 	else
117 		return mdp5_encoder_set_split_display(encoder, slave_encoder);
118 }
119 
mdp5_preclose(struct msm_kms * kms,struct drm_file * file)120 static void mdp5_preclose(struct msm_kms *kms, struct drm_file *file)
121 {
122 	struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms));
123 	struct msm_drm_private *priv = mdp5_kms->dev->dev_private;
124 	unsigned i;
125 
126 	for (i = 0; i < priv->num_crtcs; i++)
127 		mdp5_crtc_cancel_pending_flip(priv->crtcs[i], file);
128 }
129 
mdp5_destroy(struct msm_kms * kms)130 static void mdp5_destroy(struct msm_kms *kms)
131 {
132 	struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms));
133 	struct msm_mmu *mmu = mdp5_kms->mmu;
134 
135 	mdp5_irq_domain_fini(mdp5_kms);
136 
137 	if (mmu) {
138 		mmu->funcs->detach(mmu, iommu_ports, ARRAY_SIZE(iommu_ports));
139 		mmu->funcs->destroy(mmu);
140 	}
141 
142 	if (mdp5_kms->ctlm)
143 		mdp5_ctlm_destroy(mdp5_kms->ctlm);
144 	if (mdp5_kms->smp)
145 		mdp5_smp_destroy(mdp5_kms->smp);
146 	if (mdp5_kms->cfg)
147 		mdp5_cfg_destroy(mdp5_kms->cfg);
148 
149 	kfree(mdp5_kms);
150 }
151 
152 static const struct mdp_kms_funcs kms_funcs = {
153 	.base = {
154 		.hw_init         = mdp5_hw_init,
155 		.irq_preinstall  = mdp5_irq_preinstall,
156 		.irq_postinstall = mdp5_irq_postinstall,
157 		.irq_uninstall   = mdp5_irq_uninstall,
158 		.irq             = mdp5_irq,
159 		.enable_vblank   = mdp5_enable_vblank,
160 		.disable_vblank  = mdp5_disable_vblank,
161 		.prepare_commit  = mdp5_prepare_commit,
162 		.complete_commit = mdp5_complete_commit,
163 		.wait_for_crtc_commit_done = mdp5_wait_for_crtc_commit_done,
164 		.get_format      = mdp_get_format,
165 		.round_pixclk    = mdp5_round_pixclk,
166 		.set_split_display = mdp5_set_split_display,
167 		.preclose        = mdp5_preclose,
168 		.destroy         = mdp5_destroy,
169 	},
170 	.set_irqmask         = mdp5_set_irqmask,
171 };
172 
mdp5_disable(struct mdp5_kms * mdp5_kms)173 int mdp5_disable(struct mdp5_kms *mdp5_kms)
174 {
175 	DBG("");
176 
177 	clk_disable_unprepare(mdp5_kms->ahb_clk);
178 	clk_disable_unprepare(mdp5_kms->axi_clk);
179 	clk_disable_unprepare(mdp5_kms->core_clk);
180 	if (mdp5_kms->lut_clk)
181 		clk_disable_unprepare(mdp5_kms->lut_clk);
182 
183 	return 0;
184 }
185 
mdp5_enable(struct mdp5_kms * mdp5_kms)186 int mdp5_enable(struct mdp5_kms *mdp5_kms)
187 {
188 	DBG("");
189 
190 	clk_prepare_enable(mdp5_kms->ahb_clk);
191 	clk_prepare_enable(mdp5_kms->axi_clk);
192 	clk_prepare_enable(mdp5_kms->core_clk);
193 	if (mdp5_kms->lut_clk)
194 		clk_prepare_enable(mdp5_kms->lut_clk);
195 
196 	return 0;
197 }
198 
construct_encoder(struct mdp5_kms * mdp5_kms,enum mdp5_intf_type intf_type,int intf_num,enum mdp5_intf_mode intf_mode,struct mdp5_ctl * ctl)199 static struct drm_encoder *construct_encoder(struct mdp5_kms *mdp5_kms,
200 		enum mdp5_intf_type intf_type, int intf_num,
201 		enum mdp5_intf_mode intf_mode, struct mdp5_ctl *ctl)
202 {
203 	struct drm_device *dev = mdp5_kms->dev;
204 	struct msm_drm_private *priv = dev->dev_private;
205 	struct drm_encoder *encoder;
206 	struct mdp5_interface intf = {
207 			.num	= intf_num,
208 			.type	= intf_type,
209 			.mode	= intf_mode,
210 	};
211 
212 	if ((intf_type == INTF_DSI) &&
213 		(intf_mode == MDP5_INTF_DSI_MODE_COMMAND))
214 		encoder = mdp5_cmd_encoder_init(dev, &intf, ctl);
215 	else
216 		encoder = mdp5_encoder_init(dev, &intf, ctl);
217 
218 	if (IS_ERR(encoder)) {
219 		dev_err(dev->dev, "failed to construct encoder\n");
220 		return encoder;
221 	}
222 
223 	encoder->possible_crtcs = (1 << priv->num_crtcs) - 1;
224 	priv->encoders[priv->num_encoders++] = encoder;
225 
226 	return encoder;
227 }
228 
get_dsi_id_from_intf(const struct mdp5_cfg_hw * hw_cfg,int intf_num)229 static int get_dsi_id_from_intf(const struct mdp5_cfg_hw *hw_cfg, int intf_num)
230 {
231 	const enum mdp5_intf_type *intfs = hw_cfg->intf.connect;
232 	const int intf_cnt = ARRAY_SIZE(hw_cfg->intf.connect);
233 	int id = 0, i;
234 
235 	for (i = 0; i < intf_cnt; i++) {
236 		if (intfs[i] == INTF_DSI) {
237 			if (intf_num == i)
238 				return id;
239 
240 			id++;
241 		}
242 	}
243 
244 	return -EINVAL;
245 }
246 
modeset_init_intf(struct mdp5_kms * mdp5_kms,int intf_num)247 static int modeset_init_intf(struct mdp5_kms *mdp5_kms, int intf_num)
248 {
249 	struct drm_device *dev = mdp5_kms->dev;
250 	struct msm_drm_private *priv = dev->dev_private;
251 	const struct mdp5_cfg_hw *hw_cfg =
252 					mdp5_cfg_get_hw_config(mdp5_kms->cfg);
253 	enum mdp5_intf_type intf_type = hw_cfg->intf.connect[intf_num];
254 	struct mdp5_ctl_manager *ctlm = mdp5_kms->ctlm;
255 	struct mdp5_ctl *ctl;
256 	struct drm_encoder *encoder;
257 	int ret = 0;
258 
259 	switch (intf_type) {
260 	case INTF_DISABLED:
261 		break;
262 	case INTF_eDP:
263 		if (!priv->edp)
264 			break;
265 
266 		ctl = mdp5_ctlm_request(ctlm, intf_num);
267 		if (!ctl) {
268 			ret = -EINVAL;
269 			break;
270 		}
271 
272 		encoder = construct_encoder(mdp5_kms, INTF_eDP, intf_num,
273 					MDP5_INTF_MODE_NONE, ctl);
274 		if (IS_ERR(encoder)) {
275 			ret = PTR_ERR(encoder);
276 			break;
277 		}
278 
279 		ret = msm_edp_modeset_init(priv->edp, dev, encoder);
280 		break;
281 	case INTF_HDMI:
282 		if (!priv->hdmi)
283 			break;
284 
285 		ctl = mdp5_ctlm_request(ctlm, intf_num);
286 		if (!ctl) {
287 			ret = -EINVAL;
288 			break;
289 		}
290 
291 		encoder = construct_encoder(mdp5_kms, INTF_HDMI, intf_num,
292 					MDP5_INTF_MODE_NONE, ctl);
293 		if (IS_ERR(encoder)) {
294 			ret = PTR_ERR(encoder);
295 			break;
296 		}
297 
298 		ret = hdmi_modeset_init(priv->hdmi, dev, encoder);
299 		break;
300 	case INTF_DSI:
301 	{
302 		int dsi_id = get_dsi_id_from_intf(hw_cfg, intf_num);
303 		struct drm_encoder *dsi_encs[MSM_DSI_ENCODER_NUM];
304 		enum mdp5_intf_mode mode;
305 		int i;
306 
307 		if ((dsi_id >= ARRAY_SIZE(priv->dsi)) || (dsi_id < 0)) {
308 			dev_err(dev->dev, "failed to find dsi from intf %d\n",
309 				intf_num);
310 			ret = -EINVAL;
311 			break;
312 		}
313 
314 		if (!priv->dsi[dsi_id])
315 			break;
316 
317 		ctl = mdp5_ctlm_request(ctlm, intf_num);
318 		if (!ctl) {
319 			ret = -EINVAL;
320 			break;
321 		}
322 
323 		for (i = 0; i < MSM_DSI_ENCODER_NUM; i++) {
324 			mode = (i == MSM_DSI_CMD_ENCODER_ID) ?
325 				MDP5_INTF_DSI_MODE_COMMAND :
326 				MDP5_INTF_DSI_MODE_VIDEO;
327 			dsi_encs[i] = construct_encoder(mdp5_kms, INTF_DSI,
328 							intf_num, mode, ctl);
329 			if (IS_ERR(dsi_encs[i])) {
330 				ret = PTR_ERR(dsi_encs[i]);
331 				break;
332 			}
333 		}
334 
335 		ret = msm_dsi_modeset_init(priv->dsi[dsi_id], dev, dsi_encs);
336 		break;
337 	}
338 	default:
339 		dev_err(dev->dev, "unknown intf: %d\n", intf_type);
340 		ret = -EINVAL;
341 		break;
342 	}
343 
344 	return ret;
345 }
346 
modeset_init(struct mdp5_kms * mdp5_kms)347 static int modeset_init(struct mdp5_kms *mdp5_kms)
348 {
349 	static const enum mdp5_pipe crtcs[] = {
350 			SSPP_RGB0, SSPP_RGB1, SSPP_RGB2, SSPP_RGB3,
351 	};
352 	static const enum mdp5_pipe vig_planes[] = {
353 			SSPP_VIG0, SSPP_VIG1, SSPP_VIG2, SSPP_VIG3,
354 	};
355 	static const enum mdp5_pipe dma_planes[] = {
356 			SSPP_DMA0, SSPP_DMA1,
357 	};
358 	struct drm_device *dev = mdp5_kms->dev;
359 	struct msm_drm_private *priv = dev->dev_private;
360 	const struct mdp5_cfg_hw *hw_cfg;
361 	int i, ret;
362 
363 	hw_cfg = mdp5_cfg_get_hw_config(mdp5_kms->cfg);
364 
365 	/* register our interrupt-controller for hdmi/eDP/dsi/etc
366 	 * to use for irqs routed through mdp:
367 	 */
368 	ret = mdp5_irq_domain_init(mdp5_kms);
369 	if (ret)
370 		goto fail;
371 
372 	/* construct CRTCs and their private planes: */
373 	for (i = 0; i < hw_cfg->pipe_rgb.count; i++) {
374 		struct drm_plane *plane;
375 		struct drm_crtc *crtc;
376 
377 		plane = mdp5_plane_init(dev, crtcs[i], true,
378 			hw_cfg->pipe_rgb.base[i], hw_cfg->pipe_rgb.caps);
379 		if (IS_ERR(plane)) {
380 			ret = PTR_ERR(plane);
381 			dev_err(dev->dev, "failed to construct plane for %s (%d)\n",
382 					pipe2name(crtcs[i]), ret);
383 			goto fail;
384 		}
385 
386 		crtc  = mdp5_crtc_init(dev, plane, i);
387 		if (IS_ERR(crtc)) {
388 			ret = PTR_ERR(crtc);
389 			dev_err(dev->dev, "failed to construct crtc for %s (%d)\n",
390 					pipe2name(crtcs[i]), ret);
391 			goto fail;
392 		}
393 		priv->crtcs[priv->num_crtcs++] = crtc;
394 	}
395 
396 	/* Construct video planes: */
397 	for (i = 0; i < hw_cfg->pipe_vig.count; i++) {
398 		struct drm_plane *plane;
399 
400 		plane = mdp5_plane_init(dev, vig_planes[i], false,
401 			hw_cfg->pipe_vig.base[i], hw_cfg->pipe_vig.caps);
402 		if (IS_ERR(plane)) {
403 			ret = PTR_ERR(plane);
404 			dev_err(dev->dev, "failed to construct %s plane: %d\n",
405 					pipe2name(vig_planes[i]), ret);
406 			goto fail;
407 		}
408 	}
409 
410 	/* DMA planes */
411 	for (i = 0; i < hw_cfg->pipe_dma.count; i++) {
412 		struct drm_plane *plane;
413 
414 		plane = mdp5_plane_init(dev, dma_planes[i], false,
415 				hw_cfg->pipe_dma.base[i], hw_cfg->pipe_dma.caps);
416 		if (IS_ERR(plane)) {
417 			ret = PTR_ERR(plane);
418 			dev_err(dev->dev, "failed to construct %s plane: %d\n",
419 					pipe2name(dma_planes[i]), ret);
420 			goto fail;
421 		}
422 	}
423 
424 	/* Construct encoders and modeset initialize connector devices
425 	 * for each external display interface.
426 	 */
427 	for (i = 0; i < ARRAY_SIZE(hw_cfg->intf.connect); i++) {
428 		ret = modeset_init_intf(mdp5_kms, i);
429 		if (ret)
430 			goto fail;
431 	}
432 
433 	return 0;
434 
435 fail:
436 	return ret;
437 }
438 
read_hw_revision(struct mdp5_kms * mdp5_kms,uint32_t * major,uint32_t * minor)439 static void read_hw_revision(struct mdp5_kms *mdp5_kms,
440 		uint32_t *major, uint32_t *minor)
441 {
442 	uint32_t version;
443 
444 	mdp5_enable(mdp5_kms);
445 	version = mdp5_read(mdp5_kms, REG_MDSS_HW_VERSION);
446 	mdp5_disable(mdp5_kms);
447 
448 	*major = FIELD(version, MDSS_HW_VERSION_MAJOR);
449 	*minor = FIELD(version, MDSS_HW_VERSION_MINOR);
450 
451 	DBG("MDP5 version v%d.%d", *major, *minor);
452 }
453 
get_clk(struct platform_device * pdev,struct clk ** clkp,const char * name,bool mandatory)454 static int get_clk(struct platform_device *pdev, struct clk **clkp,
455 		const char *name, bool mandatory)
456 {
457 	struct device *dev = &pdev->dev;
458 	struct clk *clk = devm_clk_get(dev, name);
459 	if (IS_ERR(clk) && mandatory) {
460 		dev_err(dev, "failed to get %s (%ld)\n", name, PTR_ERR(clk));
461 		return PTR_ERR(clk);
462 	}
463 	if (IS_ERR(clk))
464 		DBG("skipping %s", name);
465 	else
466 		*clkp = clk;
467 
468 	return 0;
469 }
470 
mdp5_kms_init(struct drm_device * dev)471 struct msm_kms *mdp5_kms_init(struct drm_device *dev)
472 {
473 	struct platform_device *pdev = dev->platformdev;
474 	struct mdp5_cfg *config;
475 	struct mdp5_kms *mdp5_kms;
476 	struct msm_kms *kms = NULL;
477 	struct msm_mmu *mmu;
478 	uint32_t major, minor;
479 	int i, ret;
480 
481 	mdp5_kms = kzalloc(sizeof(*mdp5_kms), GFP_KERNEL);
482 	if (!mdp5_kms) {
483 		dev_err(dev->dev, "failed to allocate kms\n");
484 		ret = -ENOMEM;
485 		goto fail;
486 	}
487 
488 	spin_lock_init(&mdp5_kms->resource_lock);
489 
490 	mdp_kms_init(&mdp5_kms->base, &kms_funcs);
491 
492 	kms = &mdp5_kms->base.base;
493 
494 	mdp5_kms->dev = dev;
495 
496 	/* mdp5_kms->mmio actually represents the MDSS base address */
497 	mdp5_kms->mmio = msm_ioremap(pdev, "mdp_phys", "MDP5");
498 	if (IS_ERR(mdp5_kms->mmio)) {
499 		ret = PTR_ERR(mdp5_kms->mmio);
500 		goto fail;
501 	}
502 
503 	mdp5_kms->vbif = msm_ioremap(pdev, "vbif_phys", "VBIF");
504 	if (IS_ERR(mdp5_kms->vbif)) {
505 		ret = PTR_ERR(mdp5_kms->vbif);
506 		goto fail;
507 	}
508 
509 	mdp5_kms->vdd = devm_regulator_get(&pdev->dev, "vdd");
510 	if (IS_ERR(mdp5_kms->vdd)) {
511 		ret = PTR_ERR(mdp5_kms->vdd);
512 		goto fail;
513 	}
514 
515 	ret = regulator_enable(mdp5_kms->vdd);
516 	if (ret) {
517 		dev_err(dev->dev, "failed to enable regulator vdd: %d\n", ret);
518 		goto fail;
519 	}
520 
521 	/* mandatory clocks: */
522 	ret = get_clk(pdev, &mdp5_kms->axi_clk, "bus_clk", true);
523 	if (ret)
524 		goto fail;
525 	ret = get_clk(pdev, &mdp5_kms->ahb_clk, "iface_clk", true);
526 	if (ret)
527 		goto fail;
528 	ret = get_clk(pdev, &mdp5_kms->src_clk, "core_clk_src", true);
529 	if (ret)
530 		goto fail;
531 	ret = get_clk(pdev, &mdp5_kms->core_clk, "core_clk", true);
532 	if (ret)
533 		goto fail;
534 	ret = get_clk(pdev, &mdp5_kms->vsync_clk, "vsync_clk", true);
535 	if (ret)
536 		goto fail;
537 
538 	/* optional clocks: */
539 	get_clk(pdev, &mdp5_kms->lut_clk, "lut_clk", false);
540 
541 	/* we need to set a default rate before enabling.  Set a safe
542 	 * rate first, then figure out hw revision, and then set a
543 	 * more optimal rate:
544 	 */
545 	clk_set_rate(mdp5_kms->src_clk, 200000000);
546 
547 	read_hw_revision(mdp5_kms, &major, &minor);
548 
549 	mdp5_kms->cfg = mdp5_cfg_init(mdp5_kms, major, minor);
550 	if (IS_ERR(mdp5_kms->cfg)) {
551 		ret = PTR_ERR(mdp5_kms->cfg);
552 		mdp5_kms->cfg = NULL;
553 		goto fail;
554 	}
555 
556 	config = mdp5_cfg_get_config(mdp5_kms->cfg);
557 	mdp5_kms->caps = config->hw->mdp.caps;
558 
559 	/* TODO: compute core clock rate at runtime */
560 	clk_set_rate(mdp5_kms->src_clk, config->hw->max_clk);
561 
562 	/*
563 	 * Some chipsets have a Shared Memory Pool (SMP), while others
564 	 * have dedicated latency buffering per source pipe instead;
565 	 * this section initializes the SMP:
566 	 */
567 	if (mdp5_kms->caps & MDP_CAP_SMP) {
568 		mdp5_kms->smp = mdp5_smp_init(mdp5_kms->dev, &config->hw->smp);
569 		if (IS_ERR(mdp5_kms->smp)) {
570 			ret = PTR_ERR(mdp5_kms->smp);
571 			mdp5_kms->smp = NULL;
572 			goto fail;
573 		}
574 	}
575 
576 	mdp5_kms->ctlm = mdp5_ctlm_init(dev, mdp5_kms->mmio, mdp5_kms->cfg);
577 	if (IS_ERR(mdp5_kms->ctlm)) {
578 		ret = PTR_ERR(mdp5_kms->ctlm);
579 		mdp5_kms->ctlm = NULL;
580 		goto fail;
581 	}
582 
583 	/* make sure things are off before attaching iommu (bootloader could
584 	 * have left things on, in which case we'll start getting faults if
585 	 * we don't disable):
586 	 */
587 	mdp5_enable(mdp5_kms);
588 	for (i = 0; i < MDP5_INTF_NUM_MAX; i++) {
589 		if (mdp5_cfg_intf_is_virtual(config->hw->intf.connect[i]) ||
590 				!config->hw->intf.base[i])
591 			continue;
592 		mdp5_write(mdp5_kms, REG_MDP5_INTF_TIMING_ENGINE_EN(i), 0);
593 	}
594 	mdp5_disable(mdp5_kms);
595 	mdelay(16);
596 
597 	if (config->platform.iommu) {
598 		mmu = msm_iommu_new(&pdev->dev, config->platform.iommu);
599 		if (IS_ERR(mmu)) {
600 			ret = PTR_ERR(mmu);
601 			dev_err(dev->dev, "failed to init iommu: %d\n", ret);
602 			iommu_domain_free(config->platform.iommu);
603 			goto fail;
604 		}
605 
606 		ret = mmu->funcs->attach(mmu, iommu_ports,
607 				ARRAY_SIZE(iommu_ports));
608 		if (ret) {
609 			dev_err(dev->dev, "failed to attach iommu: %d\n", ret);
610 			mmu->funcs->destroy(mmu);
611 			goto fail;
612 		}
613 	} else {
614 		dev_info(dev->dev, "no iommu, fallback to phys "
615 				"contig buffers for scanout\n");
616 		mmu = NULL;
617 	}
618 	mdp5_kms->mmu = mmu;
619 
620 	mdp5_kms->id = msm_register_mmu(dev, mmu);
621 	if (mdp5_kms->id < 0) {
622 		ret = mdp5_kms->id;
623 		dev_err(dev->dev, "failed to register mdp5 iommu: %d\n", ret);
624 		goto fail;
625 	}
626 
627 	ret = modeset_init(mdp5_kms);
628 	if (ret) {
629 		dev_err(dev->dev, "modeset_init failed: %d\n", ret);
630 		goto fail;
631 	}
632 
633 	dev->mode_config.min_width = 0;
634 	dev->mode_config.min_height = 0;
635 	dev->mode_config.max_width = config->hw->lm.max_width;
636 	dev->mode_config.max_height = config->hw->lm.max_height;
637 
638 	return kms;
639 
640 fail:
641 	if (kms)
642 		mdp5_destroy(kms);
643 	return ERR_PTR(ret);
644 }
645