Lines Matching refs:that
5 patches. One of the biggest mistakes that even experienced kernel
6 developers can make is to conclude that their work is now done. In truth,
10 It is a rare patch which is so good at its first posting that there is no
13 code. You, as the author of that code, will be expected to work with the
14 kernel community to ensure that your code is up to the kernel's quality
28 value and why you went to the trouble of writing it. But that value
32 to substantial rewrites - come from the understanding that Linux will
45 be working on the kernel years from now, but they understand that their
50 What all of this comes down to is that, when reviewers send you comments,
51 you need to pay attention to the technical observations that they are
52 making. Do not let their form of expression or your own pride keep that
55 that the reviewer is asking you to fix. And respond back to the reviewer:
58 Note that you do not have to agree with every change suggested by
59 reviewers. If you believe that the reviewer has misunderstood your code,
66 that you don't realize that something is fundamentally wrong or, perhaps,
69 Andrew Morton has suggested that every review comment which does not result
70 in a code change should result in an additional code comment instead; that
74 One fatal mistake is to ignore review comments in the hope that they will
77 that your patches go nowhere.
79 Speaking of reposting code: please bear in mind that reviewers are not
91 honestly believe that this decision is going against you wrongly, you can
92 always try appealing to a higher power. As of this writing, that higher
97 in mind, of course, that he may not agree with you either.
104 entry into a subsystem maintainer's tree. How that works varies from one
116 patch. Now other developers working with that tree will get the patch by
119 there's a good chance that you will get more comments from a new set of
123 is that conflicts with work being done by others turn up. In the worst
125 burner so that the remaining patches can be worked into shape and merged.
127 developers and, possibly, moving some patches between trees to ensure that
133 Some day, if all goes well, you'll log on and see that your patch has been
142 longer any question of your code being merged. Resist that temptation,
163 fix these bugs and ensure that your code's debut in a mainline kernel
169 And don't forget that there are other milestones which may also create bug
172 respond to these reports is a matter of basic pride in your work. If that
173 is insufficient motivation, though, it's also worth considering that the
176 it with the assumption that you will not be around to maintain it
182 One day, you may open your mail client and see that somebody has mailed you
186 proper From: line so that the attribution is correct, and add a signoff of
199 developer posts a different solution to your problem. At that point,
200 chances are that one of the two patches will not be merged, and "mine was
203 really only one way to respond: be pleased that your problem got solved and